add From, To to XsvRead #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shigetaichi
commented
Oct 1, 2023
| if err := r.checkFromTo(); err != nil { | ||
| return err | ||
| } | ||
| i := 1 |
There was a problem hiding this comment.
There is a +2 in the bottom line, so the relationship must be examined.
shigetaichi
commented
Oct 1, 2023
| fieldInfo := outInnerStructInfo.Fields[j] | ||
| if err := setInnerField(&outInner, outInnerWasPointer, fieldInfo.IndexChain, csvColumnContent, fieldInfo.omitEmpty); err != nil { // Set field of struct | ||
| return &csv.ParseError{ | ||
| Line: i + 2, //add 2 to account for the header & 0-indexing of arrays |
There was a problem hiding this comment.
TODO: If From is other than 1, the value entering Line will be incorrect.
shigetaichi
force-pushed
the
fix
branch
2 times, most recently
from
3a173fa
to
e5b0241
Compare
shigetaichi
commented
Oct 5, 2023
| } else { | ||
| to = len(csvRows) | ||
| } | ||
| body := csvRows[r.From:to] |
There was a problem hiding this comment.
fromも考慮する必要がある。ヘッダーなしcsvが読み込まれている場合とか。。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.